GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: support mysql with rollup by jxnu-liguobin · Pull Request #1923 · JSQLParser/JSqlParser

Conversation

@jxnu-liguobin

@jxnu-liguobin jxnu-liguobin commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

try to closed #1907

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jxnu-liguobin added 2 commits December 18, 2023 16:19
@jxnu-liguobin
feat: support mysql with rollup
1bc7c08
@jxnu-liguobin
feat: support mysql with rollup
8bcf8c8
manticore-projects
manticore-projects requested changes Dec 18, 2023
View reviewed changes
Comment thread src/main/java/net/sf/jsqlparser/statement/select/GroupByElement.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/test/resources/net/sf/jsqlparser/statement/select/oracle-tests/merge04.sql Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects
manticore-projects reviewed Dec 18, 2023
View reviewed changes
Comment thread src/main/java/net/sf/jsqlparser/statement/select/GroupByElement.java Outdated
this.mysqlWithRollup = mysqlWithRollup;
}

public GroupByElement withMysqlWithRollup(boolean mysqlWithRollup) {

@manticore-projects manticore-projects Dec 18, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, that previously those "withMethods" have been implemented, but nobody ever gave me a reason why the "setMethod" should not return the object directly.

Feel free to avoid that redundant "withMethod" and return the object when calling the "set" method.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jxnu-liguobin jxnu-liguobin Dec 19, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my knowledge, in functional programming, it is generally referred to as with. The true meaning is to create a new object and return it without modifying the object itself, but here, with modifies the object, so set and with are indeed duplicates at this point.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@manticore-projects

manticore-projects commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

I have fixed the Test related issues not linked to this PR directly. Please re-sync, sorry for the extra step.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jxnu-liguobin
update
511cdce
@jxnu-liguobin

jxnu-liguobin commented Dec 19, 2023

Copy link
Copy Markdown
Contributor Author

I have fixed the Test related issues not linked to this PR directly. Please re-sync, sorry for the extra step.

Thank you, I have revised it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jxnu-liguobin
jxnu-liguobin requested a review from manticore-projects December 19, 2023 04:01
manticore-projects
manticore-projects approved these changes Dec 19, 2023
View reviewed changes

@manticore-projects manticore-projects left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@manticore-projects
manticore-projects merged commit 77f6fb8 into JSQLParser:master Dec 19, 2023
@manticore-projects

manticore-projects commented Dec 19, 2023

Copy link
Copy Markdown
Contributor

Thank you for working on this!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manticore-projects manticore-projects manticore-projects approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WITH ROLLUP clause

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jxnu-liguobin @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.