GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Build with Automatic-Module-Name for compatibility with the Java module system. by broneill · Pull Request #1941 · JSQLParser/JSqlParser

Conversation

@broneill

@broneill broneill commented Jan 6, 2024

Copy link
Copy Markdown
Contributor

I use the Java module system with my project, but JSQLParser doesn't use modules. As a result, I need to use the --add-reads ALL-UNNAMED hack in order to depend on it.

Building a project with the Automatic-Module-Name feature allows it to work with the module system, but without actually depending on the module system itself. This change makes it easier to integrate JSQLParser with projects that are using the Java module system.

I ran both the Maven and Gradle builds and verified that Automatic-Module-Name: net.sf.jsqlparser appears in the jar's MANIFEST.MF file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@broneill
Build with Automatic-Module-Name for compatibility with the Java modu…
4b01ce4 
…le system.
@broneill broneill changed the title Build with Automatic-Module-Name for compatibility with the Java module system. feat: Build with Automatic-Module-Name for compatibility with the Java module system. Jan 6, 2024
@manticore-projects

manticore-projects commented Jan 6, 2024

Copy link
Copy Markdown
Contributor

It does not harm, I guess.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 92e02c6 into JSQLParser:master Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@broneill @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.