GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: tables not find in parentheses join sql. by Hanchers · Pull Request #1956 · JSQLParser/JSqlParser

Conversation

@Hanchers

@Hanchers Hanchers commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

to fix bug #1955

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Hanchers added 2 commits February 6, 2024 17:09
@Hanchers
fix: tables not find in parentheses join sql.
514db35
@Hanchers
fix: test unit fix
02a4442
@manticore-projects

manticore-projects commented Feb 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thank you for your contribution and the fix, please see my comments.
The Spotless Formatter also raised concerns.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Hanchers
fix: code format
5e916a4
@Hanchers

Hanchers commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

I still see the "star" imports, please import Classes explicitly instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Hanchers
fix: remove import *
cbd8a32
@Hanchers

Hanchers commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

I still see the "star" imports, please import Classes explicitly instead.

sorry, my idea have a auto import config that couse the "star" imports.
this time i fix this question and please review again.
thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects
manticore-projects requested changes Feb 7, 2024
View reviewed changes
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Hanchers
fix: remove import * in unit test
7b20bc0
manticore-projects
manticore-projects approved these changes Feb 7, 2024
View reviewed changes
@manticore-projects

manticore-projects commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Thank you for the corrections and your contribution. I am going to merge it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Hanchers

Hanchers commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for the corrections and your contribution. I am going to merge it.

thanks， my pleasure
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 182f484 into JSQLParser:master Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manticore-projects manticore-projects manticore-projects approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Hanchers @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.