GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: issue1875 by SheldonKubor · Pull Request #1957 · JSQLParser/JSqlParser

Conversation

@SheldonKubor

@SheldonKubor SheldonKubor commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Temporarily solve the issue 1875 #1875 .
Refactoring may take more time. And in my opinion, we should discuss how to refactor.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mjh added 2 commits February 7, 2024 10:53
mjh
fix: issue1875
683bc03
mjh
fix: code format
71db97a
@manticore-projects

manticore-projects commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

we should discuss how to refactor.

The DDL statements are a big mess, best illustrated here: https://manticore-projects.com/JSQLParser/syntax_snapshot.html#createtable
The syntax diagram does not even fit on the page.

I would like to advise for a refactoring which splits this one into many smaller, re-usable productions where grammar and code can be shared between CREATE and ALTER as much as possible -- based on the SQL:2016 standard.

A good blueprint maybe here: https://manticore-projects.com/SQL2016Parser/syntax.html#table-definition and https://manticore-projects.com/SQL2016Parser/syntax.html#alter-table-statement
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Clean and neat as always, thanks a lot for working on this. Cheers!
SheldonKubor reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 98aa90c into JSQLParser:master Feb 7, 2024
@SheldonKubor
SheldonKubor deleted the feat-issue-1875 branch February 7, 2024 08:10
@minleejae minleejae mentioned this pull request Sep 4, 2026
[BUG] JSQLParser 4.7: ADD COLUMN IF NOT EXISTS not supported #1875
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@SheldonKubor @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.