GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Fixes parsing failing for ALTER MODIFY queries not containing datatype by Tanish0019 · Pull Request #1961 · JSQLParser/JSqlParser

Conversation

@Tanish0019

@Tanish0019 Tanish0019 commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Hi, I took a pass at fixing #1727
This PR makes colDataType an optional value, so we can parse queries like
ALTER TABLE table MODIFY col1 NULL

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Tanish0019
fix: Fixes parsing failing for ALTER MODIFY queries not containing da…
b03b54d 
…tatype
@manticore-projects

manticore-projects commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Please fix the Spotless Formatter exception and then I can merge this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects
manticore-projects requested changes Feb 8, 2024
View reviewed changes
Comment thread src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Tanish0019
fixed spotcheck formatting issues
4f10cf5
@Tanish0019

Tanish0019 commented Feb 8, 2024

Copy link
Copy Markdown
Contributor Author

@manticore-projects thanks for reviewing. Addressed the issues.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

@manticore-projects thanks for reviewing. Addressed the issues.

Thanks! It looks good and I am going to merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects
manticore-projects approved these changes Feb 8, 2024
View reviewed changes
@manticore-projects
manticore-projects merged commit 029fd42 into JSQLParser:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manticore-projects manticore-projects manticore-projects approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Tanish0019 @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.