GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add additional CREATE VIEW modifiers by davidjgoss · Pull Request #1964 · JSQLParser/JSqlParser

Conversation

@davidjgoss

@davidjgoss davidjgoss commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

This PR adds

  • SECURE as a new modifier on the CREATE VIEW syntax
  • VOLATILE as an alias for the existing TEMPORARY modifier

Fixes #1959

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
davidjgoss added 2 commits February 12, 2024 12:14
@davidjgoss
feat: add volatile, alias of temp(orary)
d55586d
@davidjgoss
feat: add support for CREATE SECURE VIEW
b4fac4e
@manticore-projects

manticore-projects commented Feb 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Greetings!

Thank you for working on this. Unfortunately the tests fail. Please fix it and then I would merge it asap.
Since you introduced new tokens, you will need to Update the Keyword whitelist as explained here: https://manticore-projects.com/JSQLParser/contribution.html#manage-reserved-keywords
davidjgoss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@davidjgoss
chore: regenerate reserved keywords
76d5036
@manticore-projects

manticore-projects commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

Nice and clean! Thank you for your effort and contribution.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 67e2204 into JSQLParser:master Feb 13, 2024
@davidjgoss
davidjgoss deleted the feat/create-view-modifiers branch February 14, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] additional modifiers for CREATE VIEW

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@davidjgoss @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.