GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Avoid private tokens to be white listed and allow any word character in token value by ssteinhauser · Pull Request #2044 · JSQLParser/JSqlParser

Conversation

@ssteinhauser

@ssteinhauser ssteinhauser commented Jul 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The idea of this PR is to parse and iterate over each token definition and don't whitelist anything which is defined within a private token.
Furthermore, this PR allows any token containing word character as token value to be whitelisted.

Closes #2040, #2041

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Stefan Steinhauser
fix: Avoid private tokens to be white listed
c9feb23 
Closes JSQLParser#2040
@ssteinhauser ssteinhauser mentioned this pull request Jul 19, 2024
[BUG] Compilation error after execution of updateKeywords #2040
Closed
Stefan Steinhauser
feat: Allow all word characters as token value
322fb76 
Closes JSQLParser#2041
@ssteinhauser ssteinhauser changed the title fix: Avoid private tokens to be white listed Avoid private tokens to be white listed and allow any word character in token value Jul 19, 2024
@ssteinhauser ssteinhauser mentioned this pull request Jul 19, 2024
[BUG] REGEXP_REPLACE as LikeExpression #2041
Closed
@manticore-projects

manticore-projects commented Jul 20, 2024

Copy link
Copy Markdown
Contributor

Thank you for your interest, work and effort! I really appreciate you solving this especially when I did not find the time yet to look into it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Jul 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Please help to fix the code formatting exceptions, Run './gradlew :spotlessApply' to fix these violations.
Nevermind, I pull it as it is and reformat it.
Thank you again for this PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 821e92e into JSQLParser:master Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Compilation error after execution of updateKeywords

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ssteinhauser @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.