GeezerVison

fixes #2027

Hi, @manticore-projects
In my development environment, the NestedBracketsPerformanceTest passes successfully, but I'm not sure why the Gradle build is failing.

Hi, @manticore-projects In my development environment, the NestedBracketsPerformanceTest passes successfully, but I'm not sure why the Gradle build is failing.

Greetings!

Likely because the GitHub build environment is slower (cpu clock/speed wise) than your local environment -- meaning that your change still slows the parser down, which is not a welcome development.

@manticore-projects
I understood the cause of the problem.
I don't think I've changed the code much enough to have a big impact on the overall performance, but what should I do to fix this?

I don't think I've changed the code much enough to have a big impact on the overall performance, but what should I do to fix this?

Any change in the Grammar can have potentially big impact.
Also, the impact does not need to be big, likely just something like the "straw that broke the camel's back".

I would still merge it (and fix this performance exception manually by adding timeout). However, please address my concern on the TEXT token first -- I need it as a data type token.

@manticore-projects
I understand the potential impact of changes to the grammar and will consider ways to further enhance performance. Additionally, I have updated the code to include "TEXT" as a data type token as requested. d8fc0d8

Something is wrong. In the Github Maven task I see:

Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/JSqlParser/JSqlParser/target/generated-sources/javacc/net/sf/jsqlparser/parser/CCJSqlParser.java:[22081,7] unreachable statement

However, when pulling your PR and compile locally everything seems to work. This confuses the hell out me right now.

I have merged it and will test/fix whatever problem directly.
Thank you for your contribution. Cheers!

Your changes cause real breakage:

    case K_TEXT_LITERAL:{
      tk = jj_consume_token(K_TEXT_LITERAL);
type = tk.image;
            return new ColDataType(type, precision, scale);
      break;
      }

Although I don't understand why gradle check works but Maven does not.

@manticore-projects
I apologize for not catching this issue in my environment. It seems like it has been resolved in the main branch, so thank you for fixing it.

@manticore-projects I apologize for not catching this issue in my environment. It seems like it has been resolved in the main branch, so thank you for fixing it.

No problem at all, that's what team work is for. Thank you again for your help and contribution!
Looking forward seeing more MySQL related improvements from you. Cheers!