GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore adding extra details to unit test scenarios by nicky6s · Pull Request #2051 · JSQLParser/JSqlParser

Conversation

@nicky6s

@nicky6s nicky6s commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

I have a future change in mind to do with CTEs. When I make the PR for this change I would like the unit tests changes (if any) to be simple and easy to understand. So, before I start to look at my CTE related change, I've added extra details to the UpdateTest, InsertTest, DeleteTest and SelectTest unit test scenarios.

There are zero functionality changes made here, only unit tests updates, I've been very careful not to change any SQL statements being tested.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nicky6s
chore adding extra details to unit test scenarios
226556a
manticore-projects
manticore-projects reviewed Jul 31, 2024
View reviewed changes
Comment thread src/test/java/net/sf/jsqlparser/statement/delete/DeleteTest.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects
manticore-projects requested changes Jul 31, 2024
View reviewed changes

@manticore-projects manticore-projects left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the duplicate/redundant parser calls.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nicky6s
addressing review comments
0566fb0
@manticore-projects
manticore-projects merged commit 21c605e into JSQLParser:master Jul 31, 2024
@manticore-projects

manticore-projects commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Thank you for this contribution.
nicky6s reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nicky6s
nicky6s deleted the extra-with-unit-tests branch July 31, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manticore-projects manticore-projects manticore-projects requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nicky6s @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.