GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore removing system.out.println lines + minor clean up of unit test scripts by nicky6s · Pull Request #2060 · JSQLParser/JSqlParser

Conversation

@nicky6s

@nicky6s nicky6s commented Aug 17, 2024

Copy link
Copy Markdown
Contributor

Nothing major just clean up.

When I was working on this change I noticed a few surplus System.out.println lines. This PR removes them and cleans up a few other unit tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
nicky6s added 2 commits August 17, 2024 19:15
@nicky6s
chore removing system.out.println lines + minor clean up
424b398
@nicky6s
formatting fixes via spotlessApply
0503e32
nicky6s
nicky6s commented Aug 17, 2024
View reviewed changes
Comment thread src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java
Statement parse = CCJSqlParserUtil.parse(new StringReader(
"SELECT mongodb.test.test.intField, postgres.test.test.intField, postgres.test.test.datefield FROM mongodb.test.test JOIN postgres.postgres.test.test ON mongodb.test.test.intField = postgres.test.test.intField WHERE mongodb.test.test.intField = 123"));
System.out.println(parse.toString());
}

@nicky6s nicky6s Aug 17, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test method is a duplicate of the one above

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@manticore-projects
manticore-projects merged commit 11616a0 into JSQLParser:master Aug 19, 2024
@manticore-projects

manticore-projects commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

Thank you for this beautiful cleanup, much appreciated!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nicky6s
nicky6s deleted the unit-test-cleaning branch August 19, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nicky6s @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.