GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skyline syntax (preferring clause) by ssteinhauser · Pull Request #2078 · JSQLParser/JSqlParser

Conversation

@ssteinhauser

@ssteinhauser ssteinhauser commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

This PR implements the skyline syntax (preferring clause) of Exasol which is available for SELECT, UPDATE and DELETE statements. For more details see https://docs.exasol.com/db/latest/advanced_analytics/skyline.htm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Stefan Steinhauser added 2 commits September 13, 2024 16:40
Stefan Steinhauser
feat: Implement skyline syntax (preferring clause)
c2f3305
Stefan Steinhauser
fix: Fix codacy errors
3e2c46b
@ssteinhauser
ssteinhauser marked this pull request as draft September 16, 2024 07:37
Stefan Steinhauser added 2 commits September 16, 2024 09:45
Stefan Steinhauser
style: Execute :spotlessApply
3ef53c9
Stefan Steinhauser
fix: Remove unused import
dd06a17
@ssteinhauser
ssteinhauser marked this pull request as ready for review September 16, 2024 08:03
@manticore-projects

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Thank you much for your contribution and effort!
Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects
manticore-projects requested changes Sep 17, 2024
View reviewed changes

@manticore-projects manticore-projects left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no wild card imports (as requested by @wumpz).
Rest looks great as usual and I would merge immediately when this will have been cleaned up. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/main/java/net/sf/jsqlparser/expression/ExpressionVisitor.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/statement/select/PlainSelect.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/validation/validator/ExpressionValidator.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/main/java/net/sf/jsqlparser/util/validation/validator/ExpressionValidator.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Please check for ALL wild card imports (in case I have missed to mark one), thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ssteinhauser

ssteinhauser commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

Thank you much for your contribution and effort! Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

You're welcome and thank you also for your support!

Currently, I don't have a complete overview of Exasol syntax which is not supported by JSqlParser, but my next implementation will be the support of the IMPORT (with subimport as part of select) and EXPORT statements of Exasol.
So a 5.1 release might make sense then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ssteinhauser

ssteinhauser commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

Will do and sorry - my IDE did that automatically.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Stefan Steinhauser added 2 commits September 17, 2024 09:55
Stefan Steinhauser
refactor: Replace wildcard imports
90e852a
Stefan Steinhauser
refactor: Remove redundant imports
29e633e
@ssteinhauser
ssteinhauser requested a review from manticore-projects September 17, 2024 08:11
manticore-projects
manticore-projects approved these changes Sep 17, 2024
View reviewed changes
@manticore-projects
manticore-projects merged commit d1373c5 into JSQLParser:master Sep 17, 2024
@manticore-projects

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Please check for ALL wild card imports (in case I have missed to mark one), thanks!

Will do and sorry - my IDE did that automatically.

there should be a configuration for this (even project specific).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ssteinhauser
ssteinhauser deleted the feature/skyline-syntax branch September 17, 2024 09:32
@manticore-projects

manticore-projects commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

Thank you much for your contribution and effort! Are you planing more PRs like this? I ask to time a possible 5.1 release with you which would carry your work.

You're welcome and thank you also for your support!

Currently, I don't have a complete overview of Exasol syntax which is not supported by JSqlParser, but my next implementation will be the support of the IMPORT (with subimport as part of select) and EXPORT statements of Exasol. So a 5.1 release might make sense then.

Ok, so I would like to suggest we will wait with 5.1 for this specific stuff and then will aim for a release when this would be ready.
Cheers!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jan 5, 2025
[BUG] JSQLParser Version : 5.1 RDBMS : MySql can't parse simple update sql #2136
Closed
fix: allowing skyline keywords as columns, tables, etc. #2137
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manticore-projects manticore-projects manticore-projects approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ssteinhauser @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.