GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix parsing `ALTER TABLE ... ADD COLUMNS (...)` by njaremko · Pull Request #2087 · JSQLParser/JSqlParser

Conversation

@njaremko

@njaremko njaremko commented Oct 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The current behaviour fails when it encounters ADD COLUMNS and merges everything in the () into one string with no whitespace.

So ALTER TABLE catalog.table.name ADD COLUMNS (apples int) becomes ALTER TABLE catalog.table.name ADD COLUMNS (applesint).

This commit adds an understanding of ALTER TABLE ... ADD COLUMNS to the grammar.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bradleybuda reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
njaremko
njaremko commented Oct 15, 2024
View reviewed changes
Comment thread src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
(
<K_COLUMN> { alterExp.hasColumn(true); }
|
<K_COLUMNS> { alterExp.hasColumns(true); }

@njaremko njaremko Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I auto-formatted this file. This is the only change, but I can remove the formatting bit if that matters.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@njaremko
njaremko force-pushed the nathan/fix-alter-columns-parse branch from 84ed566 to 9672d76 Compare October 15, 2024 20:07
@manticore-projects

manticore-projects commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution, please fix formatting exception by running './gradlew :spotlessApply' to fix these violations.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@njaremko
Fix parsing ALTER TABLE ... ADD COLUMNS (...)
bcdadc8 
The current behaviour fails when it encounters `ADD COLUMNS` and merges
everything in the `()` into one string with no whitespace.

So `ALTER TABLE catalog.table.name ADD COLUMNS (apples int)` becomes
`ALTER TABLE catalog.table.name ADD COLUMNS (applesint)`.

This commit adds an understanding of how `ADD COLUMNS` to the grammar.
@njaremko
njaremko force-pushed the nathan/fix-alter-columns-parse branch from 9672d76 to bcdadc8 Compare October 23, 2024 17:45
@njaremko

njaremko commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

Done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 229099c into JSQLParser:master Oct 24, 2024
@manticore-projects

manticore-projects commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@njaremko
njaremko deleted the nathan/fix-alter-columns-parse branch October 24, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@njaremko @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.