GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix issue 2090: Correctly parse LOCK clause in ALTER TABLE statements by minleejae · Pull Request #2095 · JSQLParser/JSqlParser

Conversation

@minleejae

@minleejae minleejae commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Summary

This PR addresses issue #2090 by adding support for parsing the LOCK clause in ALTER TABLE statements in JSQLParser. Previously, the LOCK=NONE clause was incorrectly parsed as UNSPECIFIC, causing ambiguity in the interpretation of certain ALTER TABLE statements.

Changes

Updated AlterOperation enum to include LOCK.
Modified the parser to correctly identify and handle the LOCK clause.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mj-db
Add support for parsing LOCK clause in ALTER TABLE statements
6d277eb
@manticore-projects

manticore-projects commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Greetings! Looks very clean, fantastic job! Thank you for your contribution, I will merge promptly when QA/CI tests have passed! Kudos.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Please, run './gradlew :spotlessApply' to fix these violations.
minleejae reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mj-db
fix code formatting
21ce4c1
@minleejae

minleejae commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

@manticore-projects

Hi, I’m working on a personal project involving MySQL DDL, and I’ve encountered several DDL statements that are not being parsed correctly. I’m actively working on fixing as many of these issues as I can. I was wondering if you have any plans for the release date of version 5.1? I’d like to contribute as much as possible before the 5.1 release.

Thank you!
manticore-projects reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Greetings to Seoul and welcome!

I personally have only little interest in DDL outside of Oracle. So you contribution is most welcome and appreciated! Keep sending please!

All the best and cheers!
(I miss Korea so much!)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit f3f6b72 into JSQLParser:master Oct 24, 2024
@manticore-projects

manticore-projects commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Release Date for 5.1 is likely around December/January. No fixed plans, we do it when we have time.
minleejae reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@minleejae
minleejae deleted the feature/alter_lock branch November 14, 2024 08:56
@manticore-projects manticore-projects mentioned this pull request Nov 14, 2024
[FEATURE] Parsing LOCK Clause in ALTER TABLE Using JSQLParser #2090
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@minleejae @manticore-projects @mj-db
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.