GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix issue 2106: Add parsing functionality for MySQL `ADD PARTITION` and `DROP PARTITION` clauses in `ALTER TABLE` statements by minleejae · Pull Request #2107 · JSQLParser/JSqlParser

Conversation

@minleejae

@minleejae minleejae commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Summary
This PR addresses the issue with JSQLParser's inability to parse ADD PARTITION clauses in ALTER TABLE statements for MySQL 8.0. Previously, these clauses were not recognized, causing parsing errors for certain ALTER TABLE operations.

Changes

  • Updated AlterOperation enum to include ADD PARTITION.
  • Modified the parser to correctly identify and handle the ADD PARTITION clauses, allowing for accurate parsing of these statements.

References
MySQL Documentation: ALTER TABLE Partition Operations

Note
This update enables JSQLParser to parse MySQL 8.0-specific partition operations within ALTER TABLE statements, improving support for MySQL-specific syntax. Additional partition-related clauses (such as REORGANIZE PARTITION, REMOVE PARTITIONING, etc.) are planned for future implementation to fully support MySQL's ALTER TABLE partition syntax.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dongseoplee reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mj-db
feat MySQL Alter add partition
b0d6f1b
@manticore-projects

manticore-projects commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Thanks a lot, but please fix QA exceptions. I 'd like to advise to run gradle check before submitting. Cheers!

minleejae reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mj-db
fix PartitionDefinition to Serializable
d8203a3
@minleejae

minleejae commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

@manticore-projects
Hello, I think it would be helpful to include these steps in the contribution guide.
Adding instructions on running ./gradlew :spotlessApply for code formatting and gradle check for QA checks could improve the submission process and help contributors avoid similar issues. Including these steps in the contribution guidelines would make it easier for everyone to ensure code quality and consistency.

manticore-projects reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects
manticore-projects merged commit 7b0e42f into JSQLParser:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@minleejae @manticore-projects @mj-db
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.