GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Issue #2109 true and false value parsed as column instead of BooleanValue by lucarota · Pull Request #2110 · JSQLParser/JSqlParser

Conversation

@lucarota

@lucarota lucarota commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Hi all,

this patch addresses Issue #2109 in the JSQLParser library, where TRUE and FALSE were incorrectly handled as column names rather than as boolean values.

According to the SQL standard ISO/IEC 9075:2016, TRUE and FALSE are reserved keywords representing boolean literals, not column identifiers.

This patch updates the parser to recognize TRUE and FALSE as boolean literals, ensuring compliance with the SQL standard and preventing potential errors in query interpretation.

Ciao,
Luca

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lucarota-eutelsat
fix: Issue JSQLParser#2109 true and false value parsed as column inst…
1ffd2ab 
…ead of BooleanValue
@manticore-projects

manticore-projects commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Very clean, well done! Thank you for your help and contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 7acf9d5 into JSQLParser:master Nov 14, 2024
@manticore-projects manticore-projects mentioned this pull request Nov 14, 2024
[BUG] JSQLParser 5.0: Generic: Update with true as value is parsed as column #2109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lucarota @manticore-projects @lucarota-eutelsat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.