GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix null exception in ExpressionVisitorAdapter with simple INTERVAL expression by tomershay · Pull Request #2133 · JSQLParser/JSqlParser

Conversation

@tomershay

@tomershay tomershay commented Dec 28, 2024

Copy link
Copy Markdown
Contributor

ExpressionVisitorAdapter was throwing a NullPointerException when a simple INTERVAL expression was provided, which didn't contain an actual expression (.getExpression() returns null).

Sample expression that causes the issue: INTERVAL 1 DAY

This PR adds validation around that code to fix this issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tomershay
Fix null exception in ExpressionVisitorAdapter with simple INTERVAL e…
ec9a69f 
…xpression
@tomershay
tomershay force-pushed the fix_expression_adapter_simple_interval_expression branch from 82186dc to ec9a69f Compare December 28, 2024 09:22
@manticore-projects

manticore-projects commented Dec 28, 2024

Copy link
Copy Markdown
Contributor

Thank you @tomershay for fixing this, much appreciated!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit d9acb5f into JSQLParser:master Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tomershay @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.