GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: support distinctrow keyword by EmilyOng · Pull Request #2238 · JSQLParser/JSqlParser

Conversation

@EmilyOng

@EmilyOng EmilyOng commented May 12, 2025

Copy link
Copy Markdown
Contributor

This PR adds support for the DISTINCTROW keyword available in MySQL and MariaDB.

SELECT
    [ALL | DISTINCT | DISTINCTROW ]
    ....
    select_expr [, select_expr]
...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
EmilyOng
EmilyOng commented May 12, 2025
View reviewed changes
Comment thread src/main/java/net/sf/jsqlparser/statement/select/Distinct.java
this.useUnique = useUnique;
}

public boolean isUseDistinctRow() {

@EmilyOng EmilyOng May 12, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since DISTINCTROW is a synonym for DISTINCT, I re-used the existing Distinct class and only augmented it with the useDistinctRow attribute to determine the string representation of Distinct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
[ LOOKAHEAD(2) "ON" "(" distinctOn=SelectItemsList() { plainSelect.getDistinct().setOnSelectItems(distinctOn); } ")" ]
)
|
<K_DISTINCTROW> { Distinct distinct = new Distinct(); distinct.setUseDistinctRow(true); plainSelect.setDistinct(distinct); }

@EmilyOng EmilyOng May 12, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is separate from the <K_DISTINCT> case right above, because DISTINCT ON or DISTINCTROW ON is not applicable in MySQL.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@manticore-projects

manticore-projects commented May 18, 2025

Copy link
Copy Markdown
Contributor

You will need to resolve conflicts please before I can merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EmilyOng
feat: support distinctrow keyword
cdaff86
@EmilyOng
EmilyOng force-pushed the mysql-distinctrow branch from 78bfcc6 to cdaff86 Compare June 7, 2025 13:59
@EmilyOng

EmilyOng commented Jun 7, 2025

Copy link
Copy Markdown
Contributor Author

You will need to resolve conflicts please before I can merge.

Done, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit e17cdef into JSQLParser:master Jun 8, 2025
@manticore-projects

manticore-projects commented Jun 8, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EmilyOng @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.