GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(parser): allow COLLATE in ORDER BY clauses (issue #2245) by ldaIas · Pull Request #2277 · JSQLParser/JSqlParser

Conversation

@ldaIas

@ldaIas ldaIas commented Jul 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR seeks to resolve this issue: #2245 (comment).

  • In the OrderByElement() JJTree rule, introduced a new Token collateToken to capture the literal or quoted identifier following COLLATE.
  • Added a lookahead for <K_COLLATE> in the grammar so that if COLLATE appears after the expression, we wrap the existing columnReference in a new CollateExpression(columnReference, collateToken.image).
  • This ensures that COLLATE 'UND-X-ICU' (or an identifier) is parsed correctly in ORDER BY clauses.

For example, the following SQL statement would fail:

select *
from a
order by cast(a.xyz as text) collate "und-x-icu" asc nulls first

with error:
Encountered unexpected token: "COLLATE" "COLLATE" at line 1, column 46. Was expecting one of: <EOF> <ST_SEMICOLON>

Now this same statement can be parsed succesfully.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ldaIas added 2 commits July 10, 2025 17:12
@ldaIas
add collate parsing and tests for order by
b5525e0
@ldaIas
rm unnecessary test
5745187
@ldaIas
ldaIas marked this pull request as ready for review July 10, 2025 23:37
@ldaIas ldaIas mentioned this pull request Jul 10, 2025
[BUG] JSQLParser 5.1-SNAPSHOT : PostgreSQL : Fail to parse "COLLATE" in Order By clause #2245
Closed
@ldaIas
add quoted identifier for "und-x-icu"
a3df377
@manticore-projects

manticore-projects commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects
manticore-projects merged commit 8810c01 into JSQLParser:master Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ldaIas @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.