GeezerVison is showing github.com — feat(parser): allow COLLATE in ORDER BY clauses (issue #2245) by ldaIas · Pull Request #2277 · JSQLParser/JSqlParser
Conversation
ldaIas
commented
Jul 10, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This PR seeks to resolve this issue: #2245 (comment).
- In the OrderByElement() JJTree rule, introduced a new Token collateToken to capture the literal or quoted identifier following COLLATE.
- Added a lookahead for <K_COLLATE> in the grammar so that if COLLATE appears after the expression, we wrap the existing columnReference in a new CollateExpression(columnReference, collateToken.image).
- This ensures that COLLATE 'UND-X-ICU' (or an identifier) is parsed correctly in ORDER BY clauses.
For example, the following SQL statement would fail:
select *
from a
order by cast(a.xyz as text) collate "und-x-icu" asc nulls first
with error:
Encountered unexpected token: "COLLATE" "COLLATE" at line 1, column 46. Was expecting one of: <EOF> <ST_SEMICOLON>
Now this same statement can be parsed succesfully.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thank you for your contribution!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.