GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix[2290] - Fix overeager lambda function parsing by davyboyhayes · Pull Request #2293 · JSQLParser/JSqlParser

Conversation

@davyboyhayes

@davyboyhayes davyboyhayes commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

SELECT DATE_TRUNC('week',("schema"."tbl"."column" + INTERVAL '1 day')) FROM "schema"."tbl"; is parsing the ("schema"."tbl"."column" + INTERVAL '1 day') as a LambdaFunction incorrectly, and crashes out. Increasing the lookahead depth by 1 ensures it fails to match on the -> keyword (I believe), and falls into a simple expression instead.

Fixes #2290

JMH

jmh {
    includes = ['.*JSQLParserBenchmark.*']
    warmupIterations = 2
    fork = 5
    iterations = 5
    timeOnIteration = '5s'
}

After:

  33.970 ±(99.9%) 1.773 ms/op [Average]
  (min, avg, max) = (31.405, 33.970, 37.302), stdev = 2.367
  CI (99.9%): [32.197, 35.743] (assumes normal distribution)

Before:

  34.882 ±(99.9%) 1.923 ms/op [Average]
  (min, avg, max) = (31.191, 34.882, 37.406), stdev = 2.567
  CI (99.9%): [32.959, 36.805] (assumes normal distribution)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
David Hayes
Fix[2290] - Fix overeager lambda function parsing
9c8a037
`SELECT DATE_TRUNC('week',("schema"."tbl"."column" + INTERVAL '1 day')) FROM "schema"."tbl";`
is parsing the `("schema"."tbl"."column" + INTERVAL '1 day')` as a LambdaFunction incorrectly, and crashes out. Increasing the lookahead depth by 1 ensures it fails to match on the `->` keyword (I believe), and falls into a simple expression instead.

JMH
```
jmh {
    includes = ['.*JSQLParserBenchmark.*']
    warmupIterations = 2
    fork = 5
    iterations = 5
    timeOnIteration = '5s'
}
```
After:
```
  33.970 ±(99.9%) 1.773 ms/op [Average]
  (min, avg, max) = (31.405, 33.970, 37.302), stdev = 2.367
  CI (99.9%): [32.197, 35.743] (assumes normal distribution)
```
Before:
```
  34.882 ±(99.9%) 1.923 ms/op [Average]
  (min, avg, max) = (31.191, 34.882, 37.406), stdev = 2.567
  CI (99.9%): [32.959, 36.805] (assumes normal distribution)
```
@manticore-projects
manticore-projects merged commit 12489af into JSQLParser:master Aug 11, 2025
@manticore-projects

manticore-projects commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Thank you much!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@davyboyhayes
davyboyhayes deleted the fix/2290 branch August 13, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser Version 5.4-Snapshot : PostgreSQL : 2nd Function Parameter with schema/table/column can't be parsed

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@davyboyhayes @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.