GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix[2306] - Adds support for Trino UDF by davyboyhayes · Pull Request #2307 · JSQLParser/JSqlParser

Conversation

@davyboyhayes

@davyboyhayes davyboyhayes commented Sep 9, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #2306
Trino SQL allows you to specify User Defined functions in the WITH clause ahead of a statement. This adds support for this type of statement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
David Hayes
Fix[2306] - Adds support for Trino UDF
668adea 
Trino SQL allows you to specify User Defined functions in the WITH clause ahead of a statement. This adds support for this type of statement.
@davyboyhayes

davyboyhayes commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

It's almost midnight here, so I will need to do the JMH tests in the morning (~0800 UTC)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@davyboyhayes

davyboyhayes commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author 
jmh {
    includes = ['.*JSQLParserBenchmark.*']
    warmupIterations = 2
    fork = 5
    iterations = 5
    timeOnIteration = '5s'
}

After:

  34.537 ±(99.9%) 1.669 ms/op [Average]
  (min, avg, max) = (31.524, 34.537, 36.699), stdev = 2.228
  CI (99.9%): [32.869, 36.206] (assumes normal distribution)

Before:

  36.172 ±(99.9%) 0.175 ms/op [Average]
  (min, avg, max) = (35.851, 36.172, 36.662), stdev = 0.233
  CI (99.9%): [35.997, 36.347] (assumes normal distribution)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
David Hayes
Fix[2306] - Adds support for Trino UDF
398be70 
Trino SQL allows you to specify User Defined functions in the WITH clause ahead of a statement. This adds support for this type of statement.
@davyboyhayes

davyboyhayes commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

I've fixed the spotbugs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit 6ce95d5 into JSQLParser:master Sep 13, 2025
@manticore-projects

manticore-projects commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@davyboyhayes
davyboyhayes deleted the fix/2306 branch September 15, 2025 07:15
@fudianchn fudianchn mentioned this pull request Sep 17, 2026
feat: support ClickHouse WITH expression aliases including lambdas #2644
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser 5.4-SNAPSHOT : TRINO : WITH FUNCTION udf - unsupported

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@davyboyhayes @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.