GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: deprecate Join.getRightItem() and remove duplicate call by zhezzz · Pull Request #2370 · JSQLParser/JSqlParser

Conversation

@zhezzz

@zhezzz zhezzz commented Jan 24, 2026

Copy link
Copy Markdown
Contributor
  1. Mark Join.getRightItem() and setRightItem() as @deprecated since they return the same value as getFromItem().
  2. Remove the duplicate call to join.getRightItem().accept(this, context) in TablesNamesFinder.visit() method, as join.getFromItem() already processes the same FromItem object.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
zhezzz
refactor: remove duplicate getRightItem call in TablesNamesFinder
77b7994 
1. Mark Join.getRightItem() and setRightItem() as @deprecated since they return the same value as getFromItem().
2. Remove the duplicate call to join.getRightItem().accept(this, context) in TablesNamesFinder.visit() method, as join.getFromItem() already processes the same FromItem object.
@manticore-projects

manticore-projects commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

Thank you much for your contribution! Welcome to the project! I will merge asap.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects
manticore-projects merged commit fab8926 into JSQLParser:master Jan 24, 2026
3 of 6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zhezzz @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.