GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enhance FOR UPDATE support by rrobetti · Pull Request #2426 · JSQLParser/JSqlParser

Conversation

@rrobetti

@rrobetti rrobetti commented Apr 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

During tests for integration of the JSqlParser into the https://github.com/Open-J-Proxy/ojp we found some limitations on how FOR UPDATE is interpreted.
This PR adds three things:

Grammar fix — multi-table OF clause: FOR UPDATE OF t1, t2, t3 was previously broken (only a single table was accepted), causing a ParseException. This affected any SELECT, not just subselect scenarios — the for_update07.sql oracle test just happens to use a subquery in FROM.

Grammar fix — ORDER BY after FOR UPDATE: Some Oracle SQL puts ORDER BY after FOR UPDATE (non-standard ordering). This also caused a ParseException before (for_update08.sql).

ForUpdateClause API class: A convenience object returned by getForUpdate() that aggregates all lock state (mode, table list, wait options) into a single object, useful for programmatic inspection in read/write routing scenarios as described in the problem statement. It's additive — all the pre-existing getForMode(), getWait(), isNoWait(), isSkipLocked() methods still work unchanged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Copilot AI and others added 2 commits April 11, 2026 16:07
@rrobetti
feat: add ForUpdateClause class with multi-table and ORDER BY support
ab2819a
Agent-Logs-Url: https://github.com/rrobetti/JSqlParser/sessions/1a91a42d-ed37-490e-88b9-25c45e621b64

Co-authored-by: rrobetti <[email protected]>
@rrobetti
Merge pull request #1 from rrobetti/copilot/fix-select-for-update-det…
38b62e5
…ection

feat: ForUpdateClause API + multi-table OF clause + ORDER BY after FOR UPDATE
@manticore-projects
manticore-projects merged commit 2b14156 into JSQLParser:master Apr 12, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects

manticore-projects commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Good job! Thank you for your work and effort.

rrobetti reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@coderabbitai coderabbitai Bot mentioned this pull request Aug 6, 2026
fix(report): safely enable query by example carlos-emr/carlos#3339
Merged
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rrobetti @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.