GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — use Locale.ROOT for case-insensitive keyword normalisation by dxbjavid · Pull Request #2437 · JSQLParser/JSqlParser

Conversation

@dxbjavid

@dxbjavid dxbjavid commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

several parser helpers fold SQL keywords and identifiers to upper case with the no-argument toUpperCase(), which uses the JVM default locale. under a Turkish or Azeri locale a keyword containing the letter i (union, intersect, minus, time, timestamp, like and friends) folds to a dotted İ instead of ASCII I, so the following Enum.valueOf lookup throws IllegalArgumentException and a valid statement fails to parse, while deparsing emits the wrong casing. switching the conversions to Locale.ROOT keeps case folding of SQL text independent of the runtime locale.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dxbjavid
use Locale.ROOT for case-insensitive keyword normalisation
7cd4998
Signed-off-by: dxbjavid <[email protected]>
@manticore-projects

manticore-projects commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Looks good but I need to fix the build script first :-(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dxbjavid

dxbjavid commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

no rush at all. happy to rebase onto master once the build script is sorted, just give me a shout if you need anything changed on my side.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects
manticore-projects merged commit 82b7c26 into JSQLParser:master Jul 30, 2026
3 of 6 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@dxbjavid

dxbjavid commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the merge. Appreciated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dxbjavid @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.