GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: add 'K_TYPE' to KeywordOrIdentifier to allow 'type' as a column name by minleejae · Pull Request #2448 · JSQLParser/JSqlParser

Conversation

@minleejae

@minleejae minleejae commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #2447

Problem

TYPE is a non-reserved keyword in MySQL 8.0, so this is valid MySQL syntax without quoting:

ALTER TABLE nullable_tbl DROP COLUMN type;

but it fails with ParseException: Encountered unexpected token: "type" "TYPE", while the same identifier parses fine in a SELECT (via RelObjectName(), since K_TYPE is inside the non-reserved word range).

Fix

Adds K_TYPE to KeywordOrIdentifier(), following the exact same approach as #2340 (which added K_DATA for the same class of bug, see #2339).

This covers all KeywordOrIdentifier() call sites: DROP [COLUMN], RENAME [COLUMN], and CHANGE [COLUMN].

Tests

  • testAlterTableDropColumnIssue2447 — ALTER TABLE test DROP COLUMN type
  • testAlterTableChangeColumnIssue2447 — ALTER TABLE tb_test CHANGE type INT (10)
  • testAlterTableRenameColumnIssue2447 — ALTER TABLE test_table RENAME COLUMN type TO type2

Full test suite passes (4646 tests, 0 failures). JavaCC parser generation reports the same pre-existing warnings as master (#2403) with no new choice conflicts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@minleejae
fix: add 'K_TYPE' to KeywordOrIdentifier to allow 'type' as a column …
f9b5537
…name

TYPE is a non-reserved keyword in MySQL, so statements like
'ALTER TABLE tbl DROP COLUMN type' are valid without quoting.
Follows the same approach as JSQLParser#2340 (K_DATA).

Fixes JSQLParser#2447
@minleejae
minleejae force-pushed the fix/drop-column-type-keyword branch from 9c29b1f to f9b5537 Compare August 5, 2026 09:06
@manticore-projects
manticore-projects merged commit f0ba123 into JSQLParser:master Aug 5, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects

manticore-projects commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thank you much!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser 5.3 : MySQL : Cannot parse DROP COLUMN where "type" is the column name

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@minleejae @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.