GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix: add 'K_TYPE' to KeywordOrIdentifier to allow 'type' as a column name by minleejae · Pull Request #2448 · JSQLParser/JSqlParser Conversation
Contributor
Fixes #2447 Problem
ALTER TABLE nullable_tbl DROP COLUMN type; but it fails with FixAdds This covers all Tests
Full test suite passes (4646 tests, 0 failures). JavaCC parser generation reports the same pre-existing warnings as master (#2403) with no new choice conflicts.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…name TYPE is a non-reserved keyword in MySQL, so statements like 'ALTER TABLE tbl DROP COLUMN type' are valid without quoting. Follows the same approach as JSQLParser#2340 (K_DATA). Fixes JSQLParser#2447
minleejae
force-pushed
the
fix/drop-column-type-keyword
branch
from
9c29b1f to
f9b5537
Compare
Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [BUG] JSQLParser 5.3 : MySQL : Cannot parse DROP COLUMN where "type" is the column nameUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |