GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix: stop 0x hex literal from swallowing trailing whitespace (#2435) by fudianchn · Pull Request #2450 · JSQLParser/JSqlParser Conversation
Contributor
What
WhyMySQL and other dialects accept while the same literal followed by a comma parses fine — a confusing inconsistency. Root cause
The space is intentional for the HowSplit the shared token so each form gets the character class it needs:
Testing
Fixes #2435
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…ser#2435) HEX_VALUE included a space character, so the "0x" hex literal form greedily consumed trailing whitespace and any adjacent hex letters (e.g. the "F" of FROM). Consequently `SELECT 0xFF FROM t` failed with "Encountered <S_IDENTIFIER> t", while `SELECT 0xFF,1 FROM t` (comma, no space) parsed fine. The space is only required by the X'..' form, which deliberately allows internal whitespace (e.g. X'01 bc 2a', covered by StringValueTest). Split the shared token: X'..' keeps HEX_VALUE (with space), while the 0x.. form uses a new space-less HEX_DIGIT token. Signed-off-by: 付典 <[email protected]>
manticore-projects
requested changes
Uh oh!
There was an error while loading. Please reload this page. Signed-off-by: 付典 <[email protected]> Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [BUG] JSQLParser 5.4-SNAPSHOT : MySQL : 0x hexadecimal literal (0xFF) not supported as select itemUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |