GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: support nested parametric data types as CAST target by fudianchn · Pull Request #2451 · JSQLParser/JSqlParser

Conversation

@fudianchn

@fudianchn fudianchn commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What

Allow a parametric (constructor-style) data type — including a nested one such as Nullable(Decimal(10, 2)) — to be used as the target type of a CAST.

Why

ClickHouse supports parametric data types as a CAST target, and they can be nested:

SELECT CAST(x AS Nullable(Decimal(10, 2))) FROM cast_demo;

JSQLParser failed on the inner opening bracket:

ParseException: Encountered: <OPENING_BRACKET> / "(", ... Was expecting ... <CLOSING_BRACKET>

Reported in #2441.

How

The argument production of ColDataType only accepted atomic tokens (S_LONG/K_MAX with optional BYTE/CHAR, S_CHAR_LITERAL, S_IDENTIFIER, K_CHAR), so a nested parametric type was unreachable.

This adds one alternative to the argument loop: when the next token is a DATA_TYPE or identifier immediately followed by (, parse the argument as a nested ColDataType (recursing through the existing production) and store its toString() rendering in the arguments string list. The new alternative is gated by an explicit LOOKAHEAD, so the existing atomic arguments are unaffected.

Kept intentionally narrow: only parametric arguments (a type immediately followed by its own argument list) are handled. A bare type-keyword argument (e.g. String in Nullable(String)) is a separate concern and out of scope for this issue.

Testing

  • New regression test ClickHouseTest#testCastToNestedParametricTypeIssue2441 covering Nullable(Decimal(10, 2)) (the reported case) and LowCardinality(Decimal(10, 2)) (another ClickHouse parametric type wrapping a precision type). Both parse and round-trip.
  • mvn clean test: 4647 tests, 0 failures, 0 errors (26 skipped) — no regressions on the shared ColDataType production.
  • mvn spotless:check: clean.

Fixes #2441

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@fudianchn
fix: support nested parametric data types as CAST target
a0657af
ClickHouse allows parametric (constructor-style) data types as a CAST
target, including nested ones such as Nullable(Decimal(10, 2)). Parsing
failed because the argument production of ColDataType only accepted
atomic tokens (numbers, string literals, bare identifiers/keywords), so
the inner opening bracket of a nested parametric type was unexpected.

Allow an argument that is itself a parametric data type (a DATA_TYPE or
identifier immediately followed by an argument list) to be parsed as a
nested ColDataType, recursing through the existing production. The
nested type is rendered back via its toString() so the statement
round-trips.

Fixes JSQLParser#2441

Signed-off-by: 付典 <[email protected]>
@fudianchn fudianchn mentioned this pull request Aug 7, 2026
[BUG] JSQLParser 5.4-SNAPSHOT : ClickHouse : Parametric type Nullable(Decimal(p, s)) not supported as CAST target #2441
Closed
@manticore-projects
manticore-projects merged commit 3997ba4 into JSQLParser:master Aug 7, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects

manticore-projects commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution, good job!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fudianchn
fudianchn deleted the fix/clickhouse-cast-nested-parametric-type-2441 branch August 21, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser 5.4-SNAPSHOT : ClickHouse : Parametric type Nullable(Decimal(p, s)) not supported as CAST target

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@fudianchn @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.