GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix: support nested parametric data types as CAST target by fudianchn · Pull Request #2451 · JSQLParser/JSqlParser Conversation
Contributor
WhatAllow a parametric (constructor-style) data type — including a nested one such as WhyClickHouse supports parametric data types as a SELECT CAST(x AS Nullable(Decimal(10, 2))) FROM cast_demo; JSQLParser failed on the inner opening bracket: Reported in #2441. HowThe argument production of This adds one alternative to the argument loop: when the next token is a Kept intentionally narrow: only parametric arguments (a type immediately followed by its own argument list) are handled. A bare type-keyword argument (e.g. Testing
Fixes #2441
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsClickHouse allows parametric (constructor-style) data types as a CAST target, including nested ones such as Nullable(Decimal(10, 2)). Parsing failed because the argument production of ColDataType only accepted atomic tokens (numbers, string literals, bare identifiers/keywords), so the inner opening bracket of a nested parametric type was unexpected. Allow an argument that is itself a parametric data type (a DATA_TYPE or identifier immediately followed by an argument list) to be parsed as a nested ColDataType, recursing through the existing production. The nested type is rendered back via its toString() so the statement round-trips. Fixes JSQLParser#2441 Signed-off-by: 付典 <[email protected]> Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [BUG] JSQLParser 5.4-SNAPSHOT : ClickHouse : Parametric type Nullable(Decimal(p, s)) not supported as CAST targetUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |