GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: support SQL Server CREATE INDEX INCLUDE columns by jianjindream · Pull Request #2462 · JSQLParser/JSqlParser

Conversation

@jianjindream

@jianjindream jianjindream commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What changed

Added support for SQL Server CREATE INDEX ... INCLUDE (...) clauses.

CreateIndex() now consumes the INCLUDE column list directly after the index key columns and preserves the clause through the existing create-index tail parameters.

Why

K_INCLUDE was already tokenized, but the create-index grammar did not accept it after the index key columns. As a result, statements such as:

CREATE INDEX idx_a ON t1 (a) INCLUDE (b, c)

failed with a ParseException at K_INCLUDE.

Tests

  • Added a regression test covering parsing and deparsing of CREATE INDEX ... INCLUDE (b, c).
  • Verified that the regression test fails before the grammar change and passes afterward.
  • Ran:
./gradlew.bat test --tests net.sf.jsqlparser.statement.create.CreateIndexTest
./gradlew.bat spotlessApply

Fixes #2459

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jianjindream
fix: support SQL Server CREATE INDEX INCLUDE columns
bb338ef
@jianjindream
jianjindream marked this pull request as ready for review August 13, 2026 05:15
Copilot AI lite review requested due to automatic review settings August 13, 2026 05:15
Copilot started reviewing on behalf of jianjindream August 13, 2026 05:15
View session
Copilot AI reviewed Aug 13, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the CREATE INDEX grammar to accept SQL Server-style INCLUDE (...) non-key columns immediately after the index key column list, and ensures the clause is preserved through the existing “tail parameters” mechanism so it round-trips via toString() and the deparser.

Changes:

  • Updated CreateIndex() grammar to optionally parse INCLUDE (col, ...) after the index key columns and store it in tailParameters.
  • Added a regression test for parsing + deparsing CREATE INDEX ... INCLUDE (b, c) (Issue #2459).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Accepts INCLUDE (...) after index key columns and preserves it via tailParameters.
src/test/java/net/sf/jsqlparser/statement/create/CreateIndexTest.java Adds a regression test covering parse/deparse round-trip for INCLUDE columns.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@manticore-projects
manticore-projects merged commit b5adb60 into JSQLParser:master Aug 13, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser Version 5.4-SNAPSHOT : MS SQL Server: CREATE INDEX ... INCLUDE ... not support

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jianjindream @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.