GeezerVison is showing github.com — Support typed transaction starts, chaining and savepoint release by minleejae · Pull Request #2729 · JSQLParser/JSqlParser
Conversation
minleejae
commented
Sep 27, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add structured parsing for PostgreSQL/MySQL transaction starts, completion chaining and savepoint release. StartTransaction exposes the command and ordered typed modes; Commit/RollbackStatement share keyword and chain enums while retaining existing rollback APIs; ReleaseSavepointStatement preserves the name and optional SAVEPOINT keyword. Connect rendering, visitors, transaction-effect analysis, table finding and feature validators, with PostgreSQL chaining gated to version 12+.
Explicit PostgreSQL/MySQL dialects disambiguate transaction BEGIN from procedural blocks. Default BEGIN keeps its existing block behavior. PostgreSQL accepts optional commas between modes; MySQL enforces its characteristic restrictions and rejects contradictory READ ONLY/READ WRITE modes while allowing repetitions. Documentation covers that policy. MySQL completion [NO] RELEASE, XA, prepared transactions and SET TRANSACTION remain outside this PR.
Validation:
- Full Java 17 Gradle
check: 9,041 tests, zero failures/errors, 25 skipped; 77 dedicated transaction tests and zero grammar choice conflicts; formatting/static analysis passed.
- PostgreSQL 18.6 and MySQL 9.7.2/26.7.0: 165 original/
toString()/deparser executions with matching activity, modes, read-only enforcement, snapshot visibility, committed rows, CHAIN behavior and savepoint state.
- Regression coverage includes quoted savepoints, mutable ASTs, direct/Reader/utility entry points, statement boundaries, visitors, capability validation, malformed/deferred syntax, procedural-block compatibility and RELEASE identifier usage.
- An unchanged client and concrete StatementVisitor compiled against the base ran on the new runtime, including legacy rollback APIs and the new default visitor methods.
- Existing JMH corpus and configured-script smoke checks used two forks with allocation profiling; existing-corpus allocation remained approximately 7.77 MB/op. Short timing samples are not a speed claim.
References: PostgreSQL START TRANSACTION, PostgreSQL COMMIT, MySQL transaction control.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Please resolve conflicts.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|