GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: deparse casts to single-field row types by PHJ2000 · Pull Request #2757 · JSQLParser/JSqlParser

Conversation

@PHJ2000

@PHJ2000 PHJ2000 commented Oct 4, 2026

Copy link
Copy Markdown

SELECT CAST(ROW(1) AS ROW(x BIGINT)) parses successfully, but toString() and StatementDeParser both dereference a null scalar type instead of rendering the one-element row definition.

Treat any nonempty columnDefinitions list as a row target in both serializers. Add a regression that checks the parsed field metadata and independently exercises both serialization paths, plus a TRY_CAST round trip. Existing multi-field and scalar cast coverage remains in the same test class.

Validation: the new regression fails on unmodified master with both NPEs; the same query also fails with the released 5.4 artifact. mvn verify completed the full suite (9,525 tests, 0 failures/errors, 25 skipped), PMD and Checkstyle. The subsequent spotless:check requested import sorting in the two touched production files; mvn spotless:apply spotless:check then passed.

Fixes #2756.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@PHJ2000
fix: deparse casts to single-field row types
0ce3837
@manticore-projects
manticore-projects merged commit a34cfac into JSQLParser:master Oct 9, 2026
10 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@manticore-projects

manticore-projects commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Thank your very much!

PHJ2000 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser 5.4 / 5.5-SNAPSHOT: single-field ROW casts throw NPE when deparsed

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@PHJ2000 @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.