GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow `ERRORS` as an unquoted identifier by guizmaii · Pull Request #2781 · JSQLParser/JSqlParser

Conversation

@guizmaii

@guizmaii guizmaii commented Oct 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Purpose

Allow ERRORS as an unquoted identifier again. 5.4 rejects queries using it as a name, e.g. SELECT errors FROM t or a WITH errors AS (...) CTE, which DuckDB, PostgreSQL and most databases accept. We hit it on real DuckDB queries: 142 of ~500 production queries use an errors column.

Cause

ERRORS was declared in the reserved keyword block when the Exasol IMPORT/EXPORT error clauses were added (#2256). Its only uses, ERRORS INTO ... and REJECT LIMIT n ERRORS, sit behind lookaheads.

Change

  • Move K_ERRORS into NonReservedWord(), next to ERROR.
  • Remove it from keywords.rst.
  • KeywordsTest#testErrorsAsIdentifier: column, qualified column, alias, CTE and table column names.

Validation

  • Java 17 Gradle check: 10,043 tests, zero failures/errors; Spotless, Checkstyle, PMD and SpotBugs pass.
  • ExportTest and ImportTest (246 tests, including the ERRORS INTO and REJECT LIMIT n ERRORS cases) pass unchanged.

Cc @manticore-projects

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jules Ivanic
Allow ERRORS as an unquoted identifier
e31c493 
`ERRORS` was declared in the reserved keyword block when the Exasol IMPORT/EXPORT
error clauses were added (JSQLParser#2256), so 5.4 rejects queries using it as a name, e.g.
`SELECT errors FROM t` or a `WITH errors AS (...)` CTE, which DuckDB, PostgreSQL
and most databases accept.

Its only uses, `ERRORS INTO ...` and `REJECT LIMIT n ERRORS`, are behind
lookaheads, so it moves to the non-reserved keywords next to `ERROR`. The Exasol
IMPORT/EXPORT tests still pass.
Copilot AI balanced review requested due to automatic review settings October 12, 2026 23:34
Copilot AI reviewed Oct 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@guizmaii guizmaii mentioned this pull request Oct 13, 2026
Support the rest of DuckDB's CREATE MACRO syntax #2783
Merged
@manticore-projects
manticore-projects merged commit cf6c83c into JSQLParser:master Oct 13, 2026
10 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guizmaii guizmaii mentioned this pull request Oct 13, 2026
Let a dialect own its reserved keywords, starting with DuckDB #2787
Closed
@guizmaii
guizmaii deleted the fix/errors-non-reserved branch October 22, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@guizmaii @manticore-projects
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.