GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — DuckDB: accept FROM-first queries and TABLE t as subqueries and set operands by guizmaii · Pull Request #2799 · JSQLParser/JSqlParser Conversation
|
| Input | Before | After |
|---|---|---|
SELECT * FROM (FROM t), a IN (FROM u), (FROM u SELECT max(a)) |
error | sub-select |
FROM a UNION ALL FROM b, SELECT 1 EXCEPT FROM b WHERE x |
error | SetOperationList of FROM-first PlainSelects |
TABLE a UNION TABLE b ORDER BY 1, (TABLE a EXCEPT ALL TABLE b) |
error | SetOperationList of TableStatements, ORDER BY on the list |
WITH t AS (SELECT 1) TABLE t |
error | TableStatement with its WITH items, deparsed |
isParenthesedSelectAhead() / isParenthesedFromItemAhead() accept (FROM, and (TABLE when a table name follows and then ), a set operator, ORDER, LIMIT, OFFSET or FETCH. So (table = 'hits'), (table) and (table.a) stay expressions on a column named table (ClickHouse's system.parts), and Oracle's TABLE(...) is untouched.Select(), FROM-first selects and TableStatement join the alternatives that can be followed by a set operation; SetOperationList accepts them as operands and hoists a trailing ORDER BY/LIMIT/OFFSET from a last TableStatement as it does for a PlainSelect. The separate TableStatement() statement alternative is now covered by Select().isFromFirstSelectAhead() also recognises a following set operator, stops at the end of the enclosing parentheses, and follows the token chain instead of calling getToken(i) per token. A bare FROM t, also parenthesized, and pipe queries are still FromQuery.TableStatement uses Select.appendTo, and TableStatementDeParser prints the WITH clause, OPTION, FETCH and the isolation level. CREATE TABLE ... AS takes any query, e.g. TABLE a UNION TABLE b; FROM (TABLE s.t) x now parses.checkGrammarAmbiguity: no conflicts. ./gradlew check: 10,116 tests, 0 failures.test/sql, 70,729 statements): 155 more parse, none less.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…perands - `(FROM t ...)` is a sub-select wherever `(SELECT ...)` is, and a parenthesized `FROM t` without pipe operators is a FROM-first select. - FROM-first queries and `TABLE t` are set operation operands, e.g. `FROM a UNION ALL FROM b` or `TABLE a EXCEPT TABLE b`, with a trailing ORDER BY/LIMIT applying to the whole operation. - `WITH ... TABLE t` keeps and prints its WITH clause. - The FROM-first scan follows the token chain and stops at the end of the enclosing parentheses.
- `(TABLE` starts a sub-select only when a table name follows and then the end of the query, so `(table = 'hits')` and `(table)` stay expressions on a column named table. `FROM (TABLE s.t) x` now parses. - A parenthesized `FROM t` without clauses stays a `FromQuery`. - `TableStatement` uses `Select.appendTo`, and its deparser prints OPTION, FETCH and the isolation level, so `TABLE t FETCH FIRST 1 ROWS ONLY` keeps its FETCH. - `CREATE TABLE ... AS` takes any query, including `TABLE a UNION TABLE b`.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thank you! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.