GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: parse SQLite WITHOUT ROWID and STRICT table options by chinmayajha · Pull Request #2903 · JSQLParser/JSqlParser

Conversation

@chinmayajha

@chinmayajha chinmayajha commented Nov 6, 2026

Copy link
Copy Markdown

Part of #2852 (the WITHOUT ROWID and STRICT part; INSERT OR is in #2853 and UPDATE OR is in #2885).

SQLite takes a comma-separated list of table options after the column list (lang_createtable). Neither option parses:

CREATE TABLE t (a INTEGER PRIMARY KEY, b TEXT) WITHOUT ROWID
-- Expected OIDS but found ROWID
CREATE TABLE t (a INTEGER PRIMARY KEY, b TEXT) STRICT
-- Encountered: <K_STRICT> / "STRICT"

CreateTableOption() now reads WITHOUT ROWID before the existing WITHOUT OIDS branch, and STRICT as its own option. Both get a TableOption.Kind (WITHOUT_ROWID, STRICT). SQLite needs the comma in WITHOUT ROWID, STRICT (sqlite3 rejects WITHOUT ROWID STRICT), but appendTableOptionsTo joins options with a space, so it now writes , between two of these options and a space everywhere else. MySQL options print as before.

SQLiteTest covers each option, both orders and lower case, and checks the parsed kinds. Other uses of STRICT and WITHOUT (ClickHouse EXCEPT STRICT/REPLACE STRICT, function STRICT, STRICT as a name, WITHOUT OIDS, WITHOUT TIME ZONE) round-trip the same as on master. gradle check passes (on JDK 26, by overriding the 17 toolchain locally), and checkGrammarAmbiguity reports no warnings.

I used Claude to help write this, and I checked the change and the tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@chinmayajha
feat: parse SQLite WITHOUT ROWID and STRICT table options
72284c7
SQLite takes a comma-separated list of WITHOUT ROWID and STRICT after the column list. Both are now TableOption kinds, and the deparser keeps the comma SQLite requires between them.

Part of JSQLParser#2852
@chinmayajha
chinmayajha force-pushed the sqlite-without-rowid-strict branch from 7e669a1 to 72284c7 Compare November 9, 2026 13:41
@chinmayajha

chinmayajha commented Nov 11, 2026

Copy link
Copy Markdown
Author

@manticore-projects could you take a look when you have time? CI is green.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@chinmayajha
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.