GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add types export to package.json by Khauri · Pull Request #20 · JavaScriptRegenerated/yieldparser

Conversation

@Khauri

@Khauri Khauri commented Feb 9, 2024

Copy link
Copy Markdown

This PR adds the "types" field to the exports in the package.json pointed to the generated dist/index.d.ts.

Without it, my project was unable to pull any types for yieldparser, which made it a tad bit harder to work with.

This is the error typsecript reported:

Could not find a declaration file for module 'yieldparser'. 'node_modules/yieldparser/dist/yieldparser.module.js' implicitly has an 'any' type.
  There are types at 'node_modules/yieldparser/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'yieldparser' library may need to update its package.json or typings.

Let me know if you find any issues.

Also thanks for creating such a cool parser generator. I've found it really nice for things that are too complex for regex but not so much that I'd want to write a whole grammar for

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Khauri
fix: add types export to package.json
808f230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Khauri
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.