GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Implement INSERT and UPDATE parsing by gpittarelli · Pull Request #10 · JavaScriptor/js-sql-parser

Conversation

@gpittarelli

@gpittarelli gpittarelli commented Apr 10, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Implements parsing for INSERT and UPDATE queries, per the MySQL 5.7 grammar. Includes pretty printing + test cases.

(Note: for my own purposes, I've published this branch under @gpittarelli/js-sql-parser)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpittarelli
gpittarelli force-pushed the master branch from 07557f3 to 344c350 Compare April 10, 2018 01:31
@gpittarelli
Implement UPDATE
c4b1c55
@gpittarelli
gpittarelli force-pushed the master branch from 344c350 to bec7988 Compare April 10, 2018 01:32
@gpittarelli
Implement INSERT
84f4402
@gpittarelli
gpittarelli force-pushed the master branch from bec7988 to 84f4402 Compare April 10, 2018 01:57
@albin3 albin3 added the enhancement label Apr 11, 2018
@albin3

albin3 commented Apr 11, 2018

Copy link
Copy Markdown
Member

Great, i'm a little busy these days, i will review it later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpittarelli
Handle VALUES in ON DUPLICATE KEY UPDATE queries
8bc20b0
@albin3

albin3 commented Jul 15, 2018

Copy link
Copy Markdown
Member

hi, @gpittarelli .

I reviewed the insert part in this pr and there are something need to change / some questions need to confirm:

  1. following https://dev.mysql.com/doc/refman/5.7/en/insert.html , simple_table_factor grammar may be should be replaced by identifier.
  2. more test cases are needed for for the new code.
  3. suggestion: format the code more similar with document in https://dev.mysql.com/doc/refman/5.7/en/insert.html , such as there are three insert grammars in document, we also write it into three lines. So, it's more readable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gpittarelli @albin3
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.