GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — support stringifying the having keyword by ryanmentzer · Pull Request #28 · JavaScriptor/js-sql-parser

Conversation

@ryanmentzer

@ryanmentzer ryanmentzer commented Oct 21, 2019

Copy link
Copy Markdown

The important part of this pr is adding this.appendKeyword('having'); to line 110 of stringify.js and the addition of test15.

The change to package.json (using minicat) was solely to support building on a windows machine.
The remaining changes were applied by prettier and are immaterial to supporting the having keyword in stringifying.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ryanmentzer
support stringifying the having keyword
e8e7cc4
albin3
albin3 approved these changes Oct 22, 2019
View reviewed changes
@albin3 albin3 added the bug label Oct 22, 2019
@albin3
albin3 merged commit e49c67f into JavaScriptor:master Oct 22, 2019
@albin3

albin3 commented Oct 22, 2019

Copy link
Copy Markdown
Member

@ryanmentzer thanks for finding out the serious having bug and submitting this pr.

new release will come soon to make the code work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@albin3

albin3 commented Oct 22, 2019

Copy link
Copy Markdown
Member
  • [email protected] has been released.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albin3 albin3 albin3 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ryanmentzer @albin3
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.