GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — release: v1.5.0 by albin3 · Pull Request #59 · JavaScriptor/js-sql-parser

Conversation

@albin3

@albin3 albin3 commented Oct 30, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@albin3
release: v1.5.0
8043656
@albin3 albin3 added the enhancement label Oct 30, 2023
@cctv1005s

cctv1005s commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

  1. in test file, the case place holder support and place holder support2 are almost the same, what's the difference between the 2 cases, I mean, maybe place holder support2 is not necessary.

  2. It seems the syntax only support some sql like select ${a} from b rather than select a from ${a}. If that's intentional,, I think you could make it more clear in the README.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@albin3

albin3 commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

@cctv1005s

  1. place holder support2 put placeholder into quotation, it's testing placeholder feature should not affect normal use of $.

  2. since table_name is an IDENTIFIER, it's not supported yet. Will add this info to readme.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cctv1005s

cctv1005s commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

Okay, lGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@albin3
chore: add placeholder Note to readme.
203c5de
@albin3
albin3 requested a review from cctv1005s October 31, 2023 02:51
cctv1005s
cctv1005s approved these changes Oct 31, 2023
View reviewed changes
@albin3
albin3 merged commit dec1f54 into master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cctv1005s cctv1005s cctv1005s approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@albin3 @cctv1005s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.