GeezerVison is showing github.com — fix: support SQL-standard doubled quotes in string literals by eaallen · Pull Request #65 · JavaScriptor/js-sql-parser
Conversation
eaallen
commented
Jul 21, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
- The STRING lexer rules only accepted backslash escapes (
\' / \"), so MySQL/SQL-standard doubled quotes like 'O''Hare' were tokenized as two strings and failed to parse.
- Update the lexer to also accept
'' / "" inside quoted literals, matching MySQL 5.7 string literals.
- Add a regression test covering doubled single/double quotes, empty strings, and existing backslash escapes.
Test plan
-
npm test — all 37 tests pass locally
- Maintainer: rebuild (
npm run build) and cut a release so npm consumers pick up the fix
Made with Cursor
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
MySQL/SQL allow escaping a quote inside a string by doubling it
(e.g. 'O''Hare'). The lexer only recognized backslash escapes, so
these literals were split into multiple STRING tokens and failed to
parse.
Update the STRING lexer rules to accept '' and "" inside quoted
strings, matching https://dev.mysql.com/doc/refman/5.7/en/string-literals.html
Co-authored-by: Cursor <[email protected]>
|
Ahoy, this seems like a great fix to this lib! I already had to fork this project so my project could be fixed, so I am not in a rush.
But this does seem like a genuine gap this pr fixes.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.