GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add LiteRT by rosbo · Pull Request #1423 · Kaggle/docker-python

Conversation

@rosbo

@rosbo rosbo commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

https://b.corp.google.com/issues/363294326

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rosbo
Add LiteRT
e7465fc 
https://b.corp.google.com/issues/363294326
@rosbo

rosbo commented Aug 30, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Working on adding a smoke test...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rosbo

rosbo commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

@calderjo Any idea why our Jenkins pipeline doesn't kick off? I haven't contributed to docker-python lately.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rosbo
rosbo requested a review from calderjo August 30, 2024 19:36
@calderjo

calderjo commented Aug 30, 2024

Copy link
Copy Markdown
Contributor

@calderjo Any idea why our Jenkins pipeline doesn't kick off? I haven't contributed to docker-python lately.

no sure why, i just kicked it off manually rn. it must be recent, because this didn't happen in my last pr.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
calderjo
calderjo approved these changes Aug 30, 2024
View reviewed changes

@calderjo calderjo left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, saw your comment about adding a smoke test, plz do.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rosbo

rosbo commented Sep 12, 2024

Copy link
Copy Markdown
Contributor Author

I am waiting on an answer from thelitert team about a failure which prevents me from adding a smoke test: https://b.corp.google.com/issues/363294326#comment2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calderjo calderjo calderjo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rosbo @calderjo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.