GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Throttled Handler doesn't delete failed handle connections · Issue #88 · Ktt-Development/simplehttpserver

This repository was archived by the owner on Jul 31, 2022. It is now read-only.
This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Throttled Handler doesn't delete failed handle connections #88

Copy link
Copy link
Closed
Closed
Throttled Handler doesn't delete failed handle connections#88
Copy link
Assignees
Katsute
Labels
bugSomething isn't working as expectedSomething isn't working as expected

Description

@Katsute
Katsute
opened on Aug 11, 2020
Issue body actions

Prerequisites

If all checks are not passed then the issue will be closed

  • I have checked that no other similar issue already exists

Operating System: Operating system name and version
Windows 10

Release Version: Release version or branch where the issue occurred
03.05.06

Issue

Explain your issue. Add any screenshots here

If an exception is thrown in #handle the connection will not be deleted, despite being handled. This can cause ghost connections.

simplehttpserver/src/main/java/com/kttdevelopment/simplehttpserver/handler/ThrottledHandler.java

Lines 43 to 51 in 77e9449

@Override
public final void handle(final HttpExchange exchange) throws IOException{
if(throttler.addConnection(exchange)){
handler.handle(exchange);
throttler.deleteConnection(exchange);
}else{
exchange.close();
}
}

Expected Behavior

Explain what was supposed to happen

Connections should be deleted after handle (use a try finally).

Steps To Reproduce

Explain how and/or when the error occurred

Throw an exception in throttled handler.

Activity

  1. Katsute
    added
    bugSomething isn't working as expectedSomething isn't working as expected
    on Aug 11, 2020
  2. Katsute
    self-assigned this
    on Aug 11, 2020
  3. Katsute
    closed this as completedin 8326df5on Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @Katsute
    Katsute

Labels

bugSomething isn't working as expectedSomething isn't working as expected

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.