GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Optimize MODLOAD (removed WATCHLOAD) and Add CACHELOAD. by Katsute · Pull Request #107 · Ktt-Development/simplehttpserver

This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Conversation

@Katsute

@Katsute Katsute commented Oct 18, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Prerequisites

If all checks are not passed then the pull request will be closed.

  • My code follows the style listed in CONTRIBUTING.
  • I have checked that no other similar pull requests already exists.
  • Build compiles.
  • Build runs without exceptions.
  • I have added/modified documentation (if applicable).
  • I have added/modified test cases.

Changes Made

List changes made and/or relevant issues. Please keep changed in reverse chronological order (newest at top).

  • Replace WATCHLOAD with MODLOAD (more efficient) (Closes Replace WatchLoad #106)
  • Add CACHELOAD (Closes Implement caching system #80)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Katsute
start work on watchload removal
42fc9ed
@Katsute Katsute added documentation Improvements or additions to the documentation experimental An experimental feature feature request Request a feature optimization Optimizations labels Oct 18, 2020
@Katsute Katsute added this to the 4.0.0 milestone Oct 18, 2020
@Katsute Katsute self-assigned this Oct 18, 2020
@Katsute Katsute changed the title start work on watchload removal Optimize MODLOAD (was WATCHLOAD) and Add CACHELOAD. Oct 18, 2020
Katsute added 4 commits October 18, 2020 16:59
@Katsute
Make file handler more efficient
cef48c4
@Katsute
remove whitespace
499abf1
@Katsute
Fixed test failures
0f342ec
@Katsute
Fixed test failure
a95b02a
@Katsute Katsute changed the title Optimize MODLOAD (was WATCHLOAD) and Add CACHELOAD. Optimize MODLOAD (removed WATCHLOAD) and Add CACHELOAD. Oct 18, 2020
Katsute added 5 commits October 18, 2020 22:08
@Katsute
Implement cache #80
a26d1bf
@Katsute
Added test cases
0435069 
Feature is now ready for final review
@Katsute
code cleanup
ec6f142
@Katsute
README fixes
8e9cc65
@Katsute
README fixes (again)
6d8ba67
@Katsute
Katsute marked this pull request as ready for review October 19, 2020 02:58
@Katsute

Katsute commented Oct 19, 2020

Copy link
Copy Markdown
Member Author

Todo: Add one more additional test to make sure that updating a cached file doesn't update a irrelevant cached file.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Katsute added 2 commits October 19, 2020 11:17
@Katsute
Add additional check
b3a5942
@Katsute
Update readme
787a93a
@Katsute

Katsute commented Oct 19, 2020

Copy link
Copy Markdown
Member Author

CacheAdapter should keep a variable for the closest expiry, then use this to determine when to check all files to clear and set the closest expiry from this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Katsute added 2 commits October 19, 2020 16:28
@Katsute
Optimize when cache is updated
d935a6f
@Katsute
made update thread safe
c092710
@Katsute
Katsute merged commit be8d868 into main Oct 20, 2020
@Katsute
Katsute deleted the watch&cache@4788a57 branch October 20, 2020 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Katsute Katsute

Labels

documentation Improvements or additions to the documentation experimental An experimental feature feature request Request a feature optimization Optimizations

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Replace WatchLoad Implement caching system

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Katsute
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.