GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed #115, GET wildcards +& not parsed correctly by Katsute · Pull Request #116 · Ktt-Development/simplehttpserver

This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Conversation

@Katsute

@Katsute Katsute commented Nov 15, 2020

Copy link
Copy Markdown
Member

Fixed issue where wildcards + and & were decoded incorrectly, causing the GET map to be incorrect.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Katsute
Fix #115
be40336 
Issue was caused by decoder parsing an already decoded query. This would break the decoder method for characters `+` and `&`.
@Katsute Katsute added the bug Something isn't working as expected label Nov 15, 2020
@Katsute Katsute added this to the 4.2.0 milestone Nov 15, 2020
@Katsute Katsute self-assigned this Nov 15, 2020
@Katsute Katsute linked an issue Nov 15, 2020 that may be closed by this pull request
Get request does not parse wildcard characters +& correctly. #115
Closed
@Katsute
Katsute merged commit a96ae6b into main Nov 15, 2020
@Katsute
Katsute deleted the fix-get#115@165dbeb branch November 15, 2020 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Katsute Katsute

Labels

bug Something isn't working as expected

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

Get request does not parse wildcard characters +& correctly.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Katsute
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.