GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replaced RequestMethod enums with HttpRequestMethod static strings. by Katsute · Pull Request #121 · Ktt-Development/simplehttpserver

This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Conversation

@Katsute

@Katsute Katsute commented Nov 18, 2020

Copy link
Copy Markdown
Member

Prerequisites

If all checks are not passed then the pull request will be closed.

  • My code follows the style listed in CONTRIBUTING.
  • I have checked that no other similar pull requests already exists.
  • Build compiles.
  • Build runs without exceptions.
  • I have added/modified documentation (if applicable).
  • I have added/modified test cases.

Changes Made

List changes made and/or relevant issues. Please keep changed in reverse chronological order (newest at top).

  • Removed RequestMethod
  • Added HttpRequestMethod with static strings for most commonly used.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Katsute added 2 commits November 17, 2020 21:14
@Katsute
move requestmethod
197abca 
single class packages don't make any sense.
@Katsute
Replace RequestMethod with static strings
62fd275 
This change is necessary as there is no fixed list of request methods.
@Katsute Katsute added feature request Request a feature refactor Reorganized labels Nov 18, 2020
@Katsute Katsute added this to the 4.3.0 milestone Nov 18, 2020
@Katsute Katsute self-assigned this Nov 18, 2020
Katsute added 2 commits November 17, 2020 21:20
@Katsute
cleanup
274f8cc
@Katsute
Update module-info.java
d84428c
@Katsute
Katsute merged commit 361a4d9 into main Nov 18, 2020
@Katsute
Katsute deleted the move-reqmethod@b0fd553 branch November 18, 2020 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Katsute Katsute

Labels

feature request Request a feature refactor Reorganized

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Katsute
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.