GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Parse the request body before raising `HttpParserUpgrade` by Kludex · Pull Request #155 · MagicStack/httptools Conversation
Contributor
Fixes #124.
llhttp already makes this decision itself in What changes:
This matches the RFCs. A server may ignore I ran uvicorn's protocol test suite against this branch and it passes. It also fixes Kludex/uvicorn#2722. AI DisclaimerThis PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Vizonex
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Decided to review because nobody seems to be available at the moment but this looks good, I hope it's merged.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Bug report candidate: Uvicorn drops body with Upgrade: h2c + chunked" [Bug] Request body lost when Upgrade: h2c + Transfer-Encoding: chunked is usedUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |