GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Version bump of cibuildwheel by WAKayser · Pull Request #447 · MagicStack/uvloop

Conversation

@WAKayser

@WAKayser WAKayser commented Oct 23, 2021

Copy link
Copy Markdown

Update cibuildwheel to 2.2.0, which will enable musllinux wheel builds. This is useful for environments like alpine linux containers.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

br3ndonland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
WAKayser added 2 commits October 23, 2021 12:01
@WAKayser
Version bump of cibuildwheel
af07b4a
Update cibuildwheel to 2.2.0, which will enable musllinux wheel builds. This is useful for environments like alpine linux containers.
@WAKayser
update to later version with bug fixes
5c937cf
@br3ndonland

br3ndonland commented Jun 11, 2022

Copy link
Copy Markdown

Thanks for taking care of this @WAKayser. I landed here after wondering why my uvloop installs were still so slow on Alpine Linux.

Cross-referencing the related PR #435 reviewed by @fantix. Would appreciate a review here as well.

Happy to help, if there's any way I can help move this forward.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ben9923

ben9923 commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

I believe further changes are needed here.

There's currently a workaround for cffi wheels, invoking yum.

# This is needed for now because cffi has no cp310 wheels
CIBW_BEFORE_ALL_LINUX: "yum -y install libffi-devel"

Running this command on Alpine would obviously fail, so it must be changed.
One option could simply be checking if yum exists as part of the command.
Another option would be using cibuildwheel's override mechanism (toml-only, added quite recently IIRC,):

[[tool.cibuildwheel.overrides]]
select = "*-manylinux*"
before-all = "yum -y install libffi-devel"

While this is actually unnecessary now, as cffi has cp310 wheels, adding cp311 will re-introduce this requirement.
cffi also has no musllinux wheels, but it seems like the default image already has libffi-dev.

Might also be worth upgrading cibuildwheel to the latest version. It will change from manylinux2010 to manylinux2014 so if it's not desired an image would need to be set explicitly.

I would love to see musl wheels too, let me know if I can help :)
CC @elprans @fantix

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ben9923 ben9923 mentioned this pull request Jul 23, 2022
Upgrade GitHub Actions for release process #480
Merged
@fantix

fantix commented Sep 11, 2022

Copy link
Copy Markdown
Member

Thanks for the PR! This is already done now and musl wheels are built successfully in my latest test, will be included in the next release.

br3ndonland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fantix fantix closed this Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@WAKayser @br3ndonland @ben9923 @fantix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.