GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix github workflow badge by EFord36 · Pull Request #523 · MagicStack/uvloop

Conversation

@EFord36

@EFord36 EFord36 commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

At the moment, the badges show like:

Screenshot 2023-01-11 at 13 25 12

See the linked GitHub issue from the previous version of the badge for the root cause: badges/shields#8671

In summary, this type of badge was changed in a breaking fashion such that the badges were just linking to the github issue rather than showing the data. Updating the url resolves this.

Also update the link of the badge to specify the workflow file rather than the name, which matches the new behaviour of the badge.

Let me know if I need to do the Sphinx build - it looks to me like this is done within ReadTheDocs but let me know if there's anything I need to do here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@EFord36

EFord36 commented Jan 19, 2023

Copy link
Copy Markdown
Contributor Author

Ah, I see that my PR is basically a duplicate of the earlier #522 - sorry, I didn't notice that when opening it somehow, I thought I had checked open PRs and issues :/

The only difference is that my PR also changes the link targets to link to the specific file, which matches the behaviour of the badge more exactly. I think this is very minor though, and that the author of #522 should get the credit here since they beat me to it!

Happy to close, leaving open for now due to the slight difference.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@EFord36
fix github workflow badge
887430f 
See the linked GitHub issue from the previous version of the badge:
badges/shields#8671

In summary, this type of badge was changed in a breaking fashion such that
the badges were just linking to the github issue rather than showing the
data. Updating the url resolves this.

Also update the link of the badge to specify the workflow file rather
than the name, which matches the new behaviour of the badge.
@fantix

fantix commented Oct 15, 2023

Copy link
Copy Markdown
Member

No problem! I'll merge both in one squashed commit. Thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fantix

fantix commented Oct 15, 2023

Copy link
Copy Markdown
Member

Merged in #522, thanks for the PR!
EFord36 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fantix fantix closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@EFord36 @fantix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.