GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — Start unifying uvloop & winloop together (WINDOWS SUPPORT) by Vizonex · Pull Request #736 · MagicStack/uvloop Conversation
|
|
Feel free to kill the workflows for now. Something doesn't seem right at the moment. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I have successfully gotten uvloop to work on windows now. Now we just need to kill the remaining workflows up until |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@fantix I know I'm asking for quite a bit today but could you go ahead and kill all workflows up until |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh wow, this is EPIC, @Vizonex! Thank you so much for all the hard work over the years! Looks like the workflows are stopped now (sorry for missing the request!), but I would suggest running CI debugging on your fork before PR is ready, so that you'll have more timely control to kill/restart them. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ws with uvloop debug which is broken.) * add another branch to test on my end * force trigger workflow * reformat test_context with black * reformat all tests to obey flake8 * fix flake8 errors * add dns related things from winloop * try something that isn't invalid on 3.8 * reformat with black using valid 3.8 syntax and the 79 character limit * update setup.py * fix more formatting problems with test_process * uncomment trest_process_streams_pass_fds on windows * slience all other known to fail tests with windows * fix if statement for dns.pyx * silencing reamining failures * remove whitespace * update tests * update tests * skip signal test on apple for now * remove whitespace * reformat with black once more
|
@fantix I managed to get every version from 3.8-3.12 to behave, I did however have to silence a few unittests for example: Another thing to point out is that I can't seem to get windows to compile and be tested in debug-mode onto the workflows. I'm sure someone or another reviewer will figure it out for me eventually but I haven't figured that out myself yet. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Vizonex yeah I think we just need to find time and/or people to review this, as well as adding you to the uvloop maintainers, but that's up to @1st1. There are a few fixes in master branch, which may unblock a few failing CI here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Seems I had a couple conflicts to resolve. @fantix I found out that we might be able to get debug libraries for windows and others using some form of the uv package manager should I look into trying that some more? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* retain --debug and other flags when debug is used and is not windows * this addtional thing is temporary * provide some extra grace for windows 3.11 * lets bump it to 0.015 instead so that 3.12 windows has some chance of winning * give a bigger buffer and shorter timeout on windows. * readjust timeout of test_socket_cancel_sendall * mark windows as both winning and loosing this test it's an unwanted coinflip. * final straw for test_socket_cancel_sock_sendall * test_call_later_2 time decrease * last but not least
|
@fantix What other changes should I look into before finalizing the merge? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* apply cx-freeze bugfix * initiate tests over here temporarly
* skip test_create_sock_cancel_fd_leak for now... * fix tcp tests for windows that weren't working previously. * really quickly let's run windows in the testsuite will get rid of this when we are done. * reformat test_tcp and reapply skipping the test_shutdown_timeout * re-remove windows branch from workflows we did our job.
There was an error while loading. Please reload this page.
|
All of the bugs and buggy tests that I could fix as of now are complete, was there anything else that I need to accomplish here? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I had a quick look at this, and it feels quite solid to me! I'll spend some time later to get the CI run again, and get a good-to-go from @1st1. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That will be wonderful. Thank you for your patience. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@fantix Seems a new bug emerged since I was last here. everything within range of 3.10 or lower seems to fail. Vizonex#13 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* implement ssss141414's fixes
|
@fantix I seem to be failing at keeping caught up with all the changes going on. I'm wondering if I should close and repoen the PR or try utilizing a different approach to get this added in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Gonna reconvert to a draft for the time being. Seems there's not enough motivation yet. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@fantix I think I'm going to close and reopen as a new PR since there are now too many branch conflicts and many new things to take account for:
Do you have any ideas on what should be done before I reattempt this or if the improvements on winloop's side need mirroring on uvloop's end first? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
At least 1 approving review is required to merge this pull request.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Windows 10 support windows support? uvloop doesn't support in windows
There was an error while loading. Please reload this page.