GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Raise TypeError for a bad subprocess pipe protocol owner by gyanu2507 · Pull Request #767 · MagicStack/uvloop

Conversation

@gyanu2507

@gyanu2507 gyanu2507 commented Sep 22, 2026

Copy link
Copy Markdown

Fixes #765.

ReadSubprocessPipeProto and WriteSubprocessPipeProto only checked proc and fd when UVLOOP_DEBUG was set. A bad proc was then cast to UVProcessTransport and the process segfaulted. That check now always runs, so the call in the report raises TypeError instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gyanu2507 added 2 commits September 22, 2026 21:19
@gyanu2507
Reject a bad subprocess pipe protocol owner with TypeError.
a76f96c 
The constructor only checked proc and fd under UVLOOP_DEBUG, then cast proc and segfaulted. That check now always runs.

Fixes MagicStack#765.
@gyanu2507
Merge upstream master into fix/subprocess-pipe-proto-type
33f9769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Directly constructed subprocess pipe protocols segfault when callbacks use a non-process owner

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@gyanu2507
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.