GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Skip tag updates if user do not have permissions (#5673) · Marcus-Rosti/feast@0a951ce

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

sdk/python/feast/infra/online_stores
- dynamodb.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎sdk/python/feast/infra/online_stores/dynamodb.py‎`

Copy file name to clipboardExpand all lines: sdk/python/feast/infra/online_stores/dynamodb.py

+12-1Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,18 @@ def update(`
`249`	`249`	`# tags won't be updated in the create_table call if the table already exists`
`250`	`250`	`if do_tag_updates[table_name]:`
`251`	`251`	`tags = self._table_tags(online_config, table_instance)`
`252`		`- self._update_tags(dynamodb_client, table_name, tags)`
	`252`	`+ try:`
	`253`	`+ self._update_tags(dynamodb_client, table_name, tags)`
	`254`	`+ except ClientError as ce:`
	`255`	`+ # If tag update fails with AccessDeniedException, log warning and continue`
	`256`	`+ # This allows Feast to work in environments where IAM roles don't have`
	`257`	`+ # dynamodb:TagResource and dynamodb:UntagResource permissions`
	`258`	`+ if ce.response["Error"]["Code"] == "AccessDeniedException":`
	`259`	`+ logger.warning(`
	`260`	`+ f"Unable to update tags for table {table_name} due to insufficient permissions."`
	`261`	`+ )`
	`262`	`+ else:`
	`263`	`+ raise`
`253`	`264`
`254`	`265`	`for table_to_delete in tables_to_delete:`
`255`	`266`	`_delete_table_idempotent(`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.