GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Optimize SQL entity handling without creating temporary tables … · Marcus-Rosti/feast@aa2c838

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

sdk/python/feast/infra/offline_stores/contrib/trino_offline_store
- trino.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py‎`

Copy file name to clipboardExpand all lines: sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -372,6 +372,8 @@ def get_historical_features(`
`372`	`372`	`)`
`373`	`373`
`374`	`374`	`# Generate the Trino SQL query from the query context`
	`375`	`+ if type(entity_df) is str:`
	`376`	`+ table_reference = f"({entity_df})"`
`375`	`377`	`query = offline_utils.build_point_in_time_query(`
`376`	`378`	`query_context,`
`377`	`379`	`left_table_query_string=table_reference,`
`@@ -454,9 +456,7 @@ def _upload_entity_df_and_get_entity_schema(`
`454`	`456`	`) -> Dict[str, np.dtype]:`
`455`	`457`	`"""Uploads a Pandas entity dataframe into a Trino table and returns the resulting table"""`
`456`	`458`	`if type(entity_df) is str:`
`457`		`- client.execute_query(f"CREATE TABLE {table_name} AS ({entity_df})")`
`458`		`-`
`459`		`- results = client.execute_query(f"SELECT * FROM {table_name} LIMIT 1")`
	`459`	`+ results = client.execute_query(f"SELECT * FROM ({entity_df}) LIMIT 1")`
`460`	`460`
`461`	`461`	`limited_entity_df = pd.DataFrame(`
`462`	`462`	`data=results.data, columns=results.columns_names`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.