GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — vendor(simplecpp): Update simplecpp.{h,cpp} to master (538c5c4); was v1.2.0 (a853253) by jcfr · Pull Request #274 · MeVisLab/pythonqt

Conversation

jcfr commented Aug 28, 2025

Copy link

Copy Markdown

Contributor

This pull request updates simplecpp anticipating the integration of changes intended to improve the generation of wrapper on macOS:

feat: Ordered search paths for -I, -isystem, -F, -iframework + Darwin framework support (with legacy -I back-compat) cppcheck-opensource/simplecpp#511

It also update the declaration of filedata variable in main.cpp to account for the introduction of simplecpp::FileDataCache structure through cppcheck-opensource/simplecpp@a0430f3 (previously it was declared as std::map<std::string, TokenList*>)

Upstream: cppcheck-opensource/simplecpp@538c5c4
Source date: 2025-08-23
Files:

generator/simplecpp/simplecpp.h
generator/simplecpp/simplecpp.cpp

Patch: generator/simplecpp/do_not_stop_on_error.patch re-applied

Compare: cppcheck-opensource/simplecpp@a853253...538c5c4

List of simplecpp changes:

$ git shortlog --no-merges a853253..538c5c4 -- simplecpp.*
Daniel Marjamäki (6):
      Fix #403 (Stack overflow in Macro::expand()) (#411)
      Fix #409 (fuzzing crash in simplecpp::Macro::expandToken()) (#412)
      Revert "fix: use both absolute and relative header paths in header matching (#362)" (#415)
      Revert "Fix #404: simplecpp::TokenList::constFold does not fold '( 0 ) && 10 < X' properly (#405)" (#416)
      Fix #446 (change the rules of relativeness preserving to depend on the source file including it for relative path includes) (#445)
      Fix #471 (preserve line splicing information in '// ..' comments) (#472)

Ludvig Gunne Lindström (3):
      Fix #454: Accept __has_include for GNU C standards (#456)
      Fix #452: Undefined function-style macro does not cause an error (#453)
      fix #459: Set __STRICT_ANSI__=1 for non-gnu standards (#460)

Oliver Stöneberg (1):
      simplecpp.cpp: fixed Visual Studio C4800 compiler warnings (#481)

Tal500 (4):
      fix: use both absolute and relative header paths in header matching (#362)
      Fix relative paths, again (#418)
      Preserve relativeness of included paths (w.r.t. current directory) (#428)
      fix: parent relative paths, and rework on the whole path extraction mechanics (#429)

clock999 (1):
      fix #337 - line splicing in comment not handled properly (#431)

glankk (8):
      Fix #381 (When there are header files with the same name, the correct file cannot be found) (#443)
      Fix #368 (__VA_OPT__ is not handled good enough) (#451)
      Fix #449 (Update c++ standard to c++11) (#450)
      Add caching of conditional directive chains (#468)
      Include and path handling optimization (#447)
      Fix #391 (`__TIME__` replacement might be empty depending on compiler) (#441)
      Remove execute bit from simplecpp.cpp/h (#494)
      Fix infinite loop with circular includes (#497)

olabetskyi (1):
      Fix #404: simplecpp::TokenList::constFold does not fold '( 0 ) && 10 < X' properly (#405)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jcfr added 2 commits

August 28, 2025 01:52


          docs: Document the exact SHA from which simplecpp sources were copied

4bfe7d5

Specifying the exact commit improves traceability.


          vendor(simplecpp): Update simplecpp.{h,cpp} to master (538c5c4); was …

f7ab8e3

…v1.2.0 (a853253)

Upstream: cppcheck-opensource/simplecpp@538c5c4
Source date: 2025-08-23
Files:   generator/simplecpp/simplecpp.h, generator/simplecpp/simplecpp.cpp
Patch:   generator/simplecpp/do_not_stop_on_error.patch re-applied

Compare: cppcheck-opensource/simplecpp@a853253...538c5c4

mrbean-bremen commented Aug 28, 2025

Copy link

Copy Markdown

Contributor

I had the slight hope that this would fix #276, but alas... still no wrappers generated under macOS in the CI.
I guess you are generating wrappers for macOS, though?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mrbean-bremen approved these changes

Aug 28, 2025

View reviewed changes

mrbean-bremen left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mrbean-bremen merged commit 4891b1b into MeVisLab:master

Aug 28, 2025

jcfr commented Aug 28, 2025

Copy link

Copy Markdown

Contributor Author

Thanks for the review 🙏 & integration 🚀

I guess you are generating wrappers for macOS, though?

Now that this is integrated, I will contribute the changes to support macOS. Those will be based of commontk/simplecpp@patched-2025-08-23-538c5c4cd including backports based of pull requests I contributed to the upstream simplecpp project that are being reviewed.

nim65s reacted with heart emoji

mrbean-bremen reacted with rocket emoji

All reactions

❤️ 1 reaction
🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jcfr deleted the update-simplecpp-to-latest branch

August 28, 2025 09:53

mrbean-bremen mentioned this pull request

Aug 28, 2025

Qt6 on macos: missing generated_cpp #276

Closed

jcfr mentioned this pull request

Sep 1, 2025

Update Slicer to use Qt6 Slicer/Slicer#6388

Open

jcfr mentioned this pull request

Nov 9, 2025

Add support for Qt 6 alongside Qt 5 commontk/CTK#1309

Merged

Reviewers

mrbean-bremen

mrbean-bremen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.